fix(opencode): normalize file tool argument aliases#29361
Closed
YOMXXX wants to merge 1 commit into
Closed
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29142
Type of change
What does this PR do?
Adds a narrow tool-execution argument normalization hook before schema decoding, then uses it for
writeandedit. The public tool JSON schemas stay canonical, but common OpenAI-compatible model aliases likepath,file_path,fileContent,old_string, andnew_stringare mapped back to the expectedfilePath,content,oldString, andnewStringkeys before validation.How did you verify your code works?
cd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun test test/tool/write.test.ts --filter "normalizes common model argument aliases"cd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun test test/tool/edit.test.ts --filter "normalizes common model argument aliases"cd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun test test/tool/write.test.ts test/tool/edit.test.ts test/tool/tool-define.test.ts test/tool/parameters.test.tscd packages/opencode && PATH="$HOME/.bun/bin:$PATH" bun typecheckgit diff --checkPATH="$HOME/.bun/bin:$PATH" .husky/pre-pushScreenshots / recordings
N/A (tool argument handling change).
Checklist